Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery to a more recent version in the docs #2557

Closed
Pezmc opened this issue Mar 1, 2016 · 8 comments
Closed

Update jQuery to a more recent version in the docs #2557

Pezmc opened this issue Mar 1, 2016 · 8 comments

Comments

@Pezmc
Copy link
Contributor

Pezmc commented Mar 1, 2016

I note it's at 1.6.4 while jQuery is now at 1.12.1. It's suggested that people use a recent build of both chosen and jQuery, the docs should probably be doing the same!

<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.6.4/jquery.min.js" type="text/javascript"></script>
@tjschuck
Copy link
Member

tjschuck commented Mar 1, 2016

@Pezmc Where do we suggest a recent build of jQuery? We support as far back as jQuery 1.4.

@koenpunt
Copy link
Collaborator

koenpunt commented Mar 1, 2016

@Pezmc probably means that jQuery suggests using their latest version. But what is the win of using it in this case?

@tjschuck
Copy link
Member

tjschuck commented Mar 1, 2016

@koenpunt He might also be referring to this comment from me about upgrading specifically from versions 1.12.0 or 2.2.0 to 1.12.1/2.2.1, but that's to fix a bug in those particular versions, not recommending a general jump beyond other old versions.

Regardless, I suppose we are on a slightly arbitrary version. We are neither on the latest version nor the oldest supported version, so I guess there's no real reason to stay where we are ¯_(ツ)_/¯

@Pezmc
Copy link
Contributor Author

Pezmc commented Mar 2, 2016

Regardless, I suppose we are on a slightly arbitrary version. We are neither on the latest version nor the oldest supported version, so I guess there's no real reason to stay where we are ¯_(ツ)_/¯

Yes that's the point I was trying to make, it seems like the number on the docs page has been chosen at random! A newer copy, or at least a copy chosen with some documented decision would make sense here.

@koenpunt
Copy link
Collaborator

koenpunt commented Mar 2, 2016

it seems like the number on the docs page has been chosen at random!

Pun intended here? 😄 But it was probably the latest version available at that time

@koenpunt
Copy link
Collaborator

koenpunt commented Mar 2, 2016

While addressing the docs, we might consider looking into this again: #1829

@tjschuck
Copy link
Member

tjschuck commented Mar 2, 2016

@Pezmc Like @koenpunt, I assume it was the latest version available the last time it was updated 😉

I'd be okay with a version bump PR.

@koenpunt
Copy link
Collaborator

koenpunt commented Oct 1, 2016

@Pezmc do you still want to address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants