Run formatter from Document directory #12315
Conversation
robgonnella
force-pushed
the
issue-10187-use-document-dir-when-formatting
branch
from
739cda7 to
75c8980
Compare
robgonnella
changed the title
|
This is an attempt to solve an issue where the external formatter is run from the directory in which helix was launched rather than from the working directory of the document / buffer being updated. In mono-repos this results in a failure to detect formatter configs in subdirectories. I'm new to Rust and this project so apologies if my approach is way off here. Any feedback is greatly appreciated! |
robgonnella
force-pushed
the
issue-10187-use-document-dir-when-formatting
branch
2 times, most recently
from
2c8fe9f to
93d1514
Compare
|
@the-mikedavis gentle ping. I know that there are a lot PRs, discussions, and work to attend to so not trying to push here, I just wasn't sure of the protocol for requesting a review and didn't see anything mentioned in the Contributing doc. Thank you for all your awesome work on Helix! It's now my daily driver! |
robgonnella
force-pushed
the
issue-10187-use-document-dir-when-formatting
branch
from
93d1514 to
d8ce8cd
Compare
| let cwd = std::env::current_dir().unwrap_or(PathBuf::from(".")); | ||
| let doc_path = self.path.clone().unwrap_or_else(|| cwd.join(self.display_name().to_string())); | ||
| let doc_dir = doc_path.parent().unwrap_or(cwd.as_path()); | ||
|
|
||
| let mut process = tokio::process::Command::new(&fmt_cmd); |
There was a problem hiding this comment.
We can avoid setting current_dir when the document doesn't have a path (i.e. is a scratch buffer) so that the process is started from the CWD instead.
if let Some(doc_dir) = self.path.as_ref().and_then(|path| path.parent()) {
process.current_dir(doc_dir);
}There was a problem hiding this comment.
Ahh nice thank you! Tested locally and this works well too. Updated PR
I thought since process.current_dir returns &mut Command that maybe it needed to be chained.
There was a problem hiding this comment.
Yeah it's a cool idiom that you can write an interface as fn foo(&mut self) -> &mut Self and use it to chain calls or to make an update in place
Fixes an issue where the external formatter is run from the directory in which helix was launched rather than from the working directory of the document / buffer being updated. In mono-repos this results in a failure to detect formatter configs in subdirectories. Addresses issue helix-editor#10187
robgonnella
force-pushed
the
issue-10187-use-document-dir-when-formatting
branch
from
d8ce8cd to
0687ac1
Compare
Addresses issue #10187