Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Index series models. #5910

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Support Index series models. #5910

merged 2 commits into from
Nov 2, 2024

Conversation

Cuiyn
Copy link
Contributor

@Cuiyn Cuiyn commented Nov 2, 2024

What does this PR do?

This PR add support for Index series models.

Before submitting

  • Did you read the contributor guideline?
  • Did you write any new necessary tests?
    (I tested and verified the effect of the added code locally)

DownloadSource.DEFAULT: "IndexTeam/Index-1.9B-Chat",
DownloadSource.MODELSCOPE: "IndexTeam/Index-1.9B-Chat",
},
"Index-1.9B-Character": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to Index-1.9B-Charater-Chat for the auto chat template

if template is not None and any(suffix in name for suffix in ("-Chat", "-Instruct")):

DownloadSource.DEFAULT: "IndexTeam/Index-1.9B-Pure",
DownloadSource.MODELSCOPE: "IndexTeam/Index-1.9B-Pure",
},
"Index-1.9B-32K": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to Index-1.9B-Chat-32K

@hiyouga hiyouga added the pending This problem is yet to be addressed label Nov 2, 2024
@Cuiyn Cuiyn requested a review from hiyouga November 2, 2024 10:04
@hiyouga
Copy link
Owner

hiyouga commented Nov 2, 2024

can you rebase this pr?
git rebase upstream/main

@Cuiyn Cuiyn force-pushed the index branch 4 times, most recently from eb6956c to a15a69a Compare November 2, 2024 11:52
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cuiyn
Copy link
Contributor Author

Cuiyn commented Nov 2, 2024

Sorry for the trouble, it's my first time working on a project of this size.

@hiyouga
Copy link
Owner

hiyouga commented Nov 2, 2024

@Cuiyn no problem, thanks for your contribution

@hiyouga hiyouga added solved This problem has been already solved and removed pending This problem is yet to be addressed labels Nov 2, 2024
@hiyouga hiyouga merged commit c58cc22 into hiyouga:main Nov 2, 2024
12 checks passed
@Cuiyn Cuiyn deleted the index branch November 26, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants