Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async dns resolver in aiohttp #114272

Closed
wants to merge 1 commit into from
Closed

Use async dns resolver in aiohttp #114272

wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 26, 2024

Proposed change

c-ares/c-ares#70 has been solved for a while so this should be ok to switch back to aiodns and avoid creating executor jobs to do dns resolution

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

c-ares/c-ares#70 has been solved for a while
so this should be ok to switch back to aiodns and avoid creating executor
jobs to do dns resolution
@@ -2,6 +2,7 @@

aiodhcpwatcher==1.0.0
aiodiscover==2.0.0
aiodns==3.1.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already going to be installed anyways since its a dep from dhcp via default_config

@bdraco
Copy link
Member Author

bdraco commented Mar 26, 2024

Testing shows it still an issue

@bdraco bdraco closed this Mar 26, 2024
@bdraco
Copy link
Member Author

bdraco commented Mar 26, 2024

This is worth fixing upstream since its generating a lot of executor jobs

aio-libs/aiohttp#6836 (comment)
aio-libs/aiodns#118

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
@bdraco bdraco deleted the asyncio_resolver branch June 7, 2024 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant