UI image loading refactor #18537
Merged
UI image loading refactor #18537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
the
Code Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
ManagedTexturewas originally meant for display of textures in the UI that would auto-reload from disk after DeviceLost/DeviceRestored.Most of the existing uses are not used that way though, it's just been used as a convenient way to load image files.
So, do some refactoring of the image load logic to get rid of nearly all of them.
The actual reason is that I'm gonna make ManagedTexture a little more complex and implement image load on thread, for faster load of save state screenshots. The pause menu is a bit sluggish to open if you have five slots with high res screenshots. But for game icons and stuff, that's just not necessary.