FIX: Sft train script FSDP QLoRA embedding mean resizing error #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resizing the embedding layer with mean_resizing=True, which has been introduced in transformers > 4.45, will result in an error. This is because for FSDP + QLoRA the embedding matrix can be on meta device, in which case mean resizing fails. Therefore, if these conditions are detected, the script will set mean_resizing=False. Also updated the recommended package versions to newer versions that I have checked to be working.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
After feedback from Zach
gante
approved these changes
Oct 16, 2024
BenjaminBossan
deleted the
fix-sft-train-script-embedding-mean-resizing
branch
sirluk
pushed a commit
to sirluk/peft
that referenced
this pull request
Oct 19, 2024
…ngface#2151) Resizing the embedding layer with mean_resizing=True, which has been introduced in transformers > 4.45, will result in an error. This is because for FSDP + QLoRA the embedding matrix can be on meta device, in which case mean resizing fails. Therefore, if these conditions are detected, the script will set mean_resizing=False. Also updated the recommended package versions to newer versions that I have checked to be working.
yaswanth19
pushed a commit
to yaswanth19/peft
that referenced
this pull request
Oct 20, 2024
…ngface#2151) Resizing the embedding layer with mean_resizing=True, which has been introduced in transformers > 4.45, will result in an error. This is because for FSDP + QLoRA the embedding matrix can be on meta device, in which case mean resizing fails. Therefore, if these conditions are detected, the script will set mean_resizing=False. Also updated the recommended package versions to newer versions that I have checked to be working.
yaswanth19
pushed a commit
to yaswanth19/peft
that referenced
this pull request
Oct 20, 2024
…ngface#2151) Resizing the embedding layer with mean_resizing=True, which has been introduced in transformers > 4.45, will result in an error. This is because for FSDP + QLoRA the embedding matrix can be on meta device, in which case mean resizing fails. Therefore, if these conditions are detected, the script will set mean_resizing=False. Also updated the recommended package versions to newer versions that I have checked to be working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resizing the embedding layer with
mean_resizing=True,which has been introduced in transformers > 4.45, will result in an error. This is because for FSDP + QLoRA the embedding matrix can be on meta device, in which case mean resizing fails. Therefore, if these conditions are detected, the script will setmean_resizing=False.Also updated the recommended package versions to newer versions that I have checked to be working.