Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation component's ready parameter is missing in TypeScript definition #1044

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Translation component's ready parameter is missing in TypeScript definition #1044

merged 2 commits into from
Jan 15, 2020

Conversation

ryanswanson
Copy link
Contributor

Added a typing and some tests that appear to have been missed in a previous feature.

  • Translation: added typing for the ready parameter and added a test to validate it.
  • useTranslation: updated TypeScript tests to validate ready return value
  • withTranslation: updated TypeScript tests to validate tReady prop (WithTranslation).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.305% when pulling 4cf890e on ryanswanson:feature/translation-component-ready-missing-in-types into 99fc5b8 on i18next:master.

@jamuhl jamuhl requested a review from rosskevin January 15, 2020 06:44
@rosskevin
Copy link
Collaborator

Thanks @ryanswanson. @jamuhl this can be a patch release.

@rosskevin rosskevin merged commit ee034bb into i18next:master Jan 15, 2020
@ryanswanson
Copy link
Contributor Author

Glad to help, @rosskevin! Thank you for the quick turn around.

@ryanswanson ryanswanson deleted the feature/translation-component-ready-missing-in-types branch January 15, 2020 20:24
@jamuhl
Copy link
Member

jamuhl commented Jan 16, 2020

thanks to all - was published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants