Avoid setState while react is rendering #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented in i18next#1124 (comment) this fix should avoid `setState` while react is rendering.
|
@jamuhl, I don't know how to fix the coverage issue, it's (I guess) a side effect which (according to the report) is not in Kind regards, |
|
@rmedaer not needed...will check PR this asap...thank you |
|
published in [email protected] Thank you for figuring this out and providing the PR. Hopefully this will not break any side cases - but looks safe in my tests. |
Thank you.
Let me know if you find related issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in my comment about issue #1124, this fix should avoid
setStatewhile react is rendering.See #1124 for more details.
Checklist
npm run testtests are includeddocumentation is changed or added