Add Windows to platforms for oj and yajl #216
Conversation
|
I had to update the bundler version so that it understood the "windows" platform. However, github actions has apparently decided to gaslight me. No matter what version of json or json_pure I specify, it says it can only find a slightly older version. So, if I tell it to use I have no clue wtf it's doing. Update: Nevermind, fixed it. |
|
|
||
| on: | ||
| push: | ||
| branches: [main, master] # TODO: rename and get rid of 'master' | ||
| # Triggers the workflow on pull request events. |
There was a problem hiding this comment.
No need to specify "opened, reopened, synchronize", those are the defaults.
| concurrency: | ||
| group: "${{ github.workflow }} @ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}" | ||
| cancel-in-progress: true | ||
|
|
There was a problem hiding this comment.
Concurrency? For a small library like this? Nah. Let's simplify.
| ruby-version: ['3.0', '3.1', '3.2', 'jruby'] | ||
| platform: [ubuntu-latest, macos-latest, windows-latest] | ||
| runs-on: ${{ matrix.platform }} | ||
|
|
There was a problem hiding this comment.
I refactored this, easier to read. This is basically the pattern I use for all of my gems.
I also added macos and windows to the platform list, and got rid of the SKIP_ADAPTERS env since you're not using it any more.
There was a problem hiding this comment.
I should also mention that I left truffleruby off for now because it smacked into some core language bug with symbol counts.
| gem install bundler | ||
| bundle install | ||
| bundle exec rake | ||
|
|
There was a problem hiding this comment.
I had to refactor this a bit because older versions of Ruby default to a version of Bundler that doesn't understand the "windows" platform for the Gemfile. Thus, the bundler-cache option is disabled, and an explicit gem install bundler step is added.
| # Allows you to run this workflow manually from the Actions tab | ||
| branches: [main, master] # TODO: rename and get rid of 'master' | ||
| paths-ignore: | ||
| - '**/*.md' |
There was a problem hiding this comment.
Minor refactor, you don't want CI running for doc changes do you? Of course not.
| gem "oj", "~> 3.0", platforms: [:ruby], require: false | ||
| gem "yajl-ruby", "~> 1.3", platforms: [:ruby], require: false | ||
| gem "oj", "~> 3.0", platforms: [:ruby, :windows], require: false | ||
| gem "yajl-ruby", "~> 1.3", platforms: [:ruby, :windows], require: false |
There was a problem hiding this comment.
The thing that started it all.
djberg96
force-pushed
the
windows_gemfile
branch
from
e8a4ad6 to
89e4590
Compare
|
@sferik Ok, ready for review. :) |
|
@sferik Thoughts? |
I forgot that "ruby" doesn't include MS Windows in the Gemfile platforms. Since it's reasonable to expect that a compiler is available on Windows these days, this should be added.
I was able to build and test this on my Windows 7 VM successfully.
In order to verify this worked I had to update the github action config, and did some refactoring while I was here.