-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade analyzer, analyzer_plugin, source_gen #300
Upgrade analyzer, analyzer_plugin, source_gen #300
Conversation
@Rexios80 is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/dart_custom_lint~300 Documentation is deployed and generated using docs.page. |
@@ -7,7 +7,7 @@ environment: | |||
sdk: ">=3.0.0 <4.0.0" | |||
|
|||
dependencies: | |||
analyzer: 6.11.0 | |||
analyzer: ^7.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A tight version is mandatory here.
And you need to re-run the generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to land rrousselGit/freezed#1140 first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why a Freezed version is necessary for custom_lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because freezed also depends on anaylzer...
I don't plan to upgrade melos |
And I'm also skeptical that Custom_lint supports analyzer 7.0 without any change :) |
I mostly made this PR to bring awareness to the need to upgrade the analyzer package. Feel free to take over and make any necessary changes. |
I'm aware of it, but analyzer 7 isn't usable by Flutter stable, is it? |
I'm on flutter stable 3.27.1 and analyzer 7 is resolving |
@rrousselGit Due to the circular dependency |
Which circular dependency are you referring to? |
I think it's just that the repos have a circular dependency (and thus the actions) and not the packages themselves. One of the freezed examples depends on custom_lint, and one of the custom_lint packages depends on freezed. |
This should be unblocked now |
There are some |
@rrousselGit I'm not sure what the issue is. It looks like maybe the |
Yes, the plugin_loader doesn't respect pubspec_overrides (not my fault, that's how Dart handles plugins 🤷) Also, don't trust that it's working for you locally. The pub cache is not invalidated enough for plugins. |
It looks like the command that's failing is just a regular |
Hum.. We probably could exclude the plugin_loader from the melos workspace. That should fix the issue |
@rrousselGit I excluded the plugin loader from the melos workspace which fixed the pub get issue, but now tests are failing |
Thanks! |
No description provided.