Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor utils #1760

Merged
merged 9 commits into from
Dec 3, 2024
Merged

chore: refactor utils #1760

merged 9 commits into from
Dec 3, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Dec 2, 2024 •
edited
Loading

Describe Your Changes

  • Move long functions into source files, this helps to reduce compile time on Windows by 50%
  • Group e2e tests

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev requested a review from a team December 3, 2024 01:04
namchuai
namchuai approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! ✅

@vansangpfiev vansangpfiev force-pushed the chore/refactor-utils branch 5 times, most recently from 584d098 to ff1cf8b Compare December 3, 2024 10:34
@vansangpfiev vansangpfiev merged commit 5eda212 into dev Dec 3, 2024
5 checks passed
@vansangpfiev vansangpfiev deleted the chore/refactor-utils branch December 3, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @sangjanai