Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop inflight chat completion #1765

Merged
merged 6 commits into from
Dec 10, 2024
Merged

fix: stop inflight chat completion #1765

merged 6 commits into from
Dec 10, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Dec 3, 2024 •
edited
Loading

Describe Your Changes

  • Signal to engine to stop inflight chat completion if it has request from client.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev marked this pull request as ready for review December 10, 2024 03:16
@vansangpfiev vansangpfiev requested a review from a team December 10, 2024 03:16
namchuai
namchuai approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@namchuai namchuai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overally looks good to me. Approved! ✅

engine/controllers/server.cc Outdated Show resolved Hide resolved
engine/controllers/server.cc Outdated Show resolved Hide resolved
engine/services/inference_service.cc Show resolved Hide resolved
engine/services/inference_service.cc Show resolved Hide resolved
@vansangpfiev vansangpfiev merged commit 4a839b4 into dev Dec 10, 2024
5 checks passed
@vansangpfiev vansangpfiev deleted the fix/stop-inflight-chat branch December 10, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @sangjanai