Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deadlock when unload engine #1769

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: deadlock when unload engine #1769

merged 2 commits into from
Dec 5, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Dec 5, 2024 •
edited
Loading

Describe Your Changes

  • We lock engines_mutex_ twice

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@vansangpfiev vansangpfiev requested a review from a team December 5, 2024 04:23
@vansangpfiev vansangpfiev merged commit a49054c into dev Dec 5, 2024
5 checks passed
@vansangpfiev vansangpfiev deleted the fix/unload-engine-deadlock branch December 5, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vansangpfiev @namchuai