Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove sort msg by ulid #1799

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix: remove sort msg by ulid #1799

merged 1 commit into from
Dec 16, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Remove sort msg by ulid to supporting jan.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

louis-jan
louis-jan reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @namchuai

@namchuai namchuai merged commit 2ef085a into dev Dec 16, 2024
5 checks passed
@namchuai namchuai deleted the j/remove-sort-message-by-ulid branch December 16, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan left review comments

@vansangpfiev vansangpfiev vansangpfiev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@namchuai @vansangpfiev @louis-jan