Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
engine/services/engine_service.cc
file to improve the handling of paths in theLoadEngine
andRegisterEngineLibPath
methods. The most important changes involve the removal of buggystd::move
(use after move) operations when pushing back paths into thestd::vector
.Codebase simplification:
engine/services/engine_service.cc
: Removed unnecessarystd::move
operations when pushingcuda_path
andengine_dir_path
into thepaths
vector in both theLoadEngine
andRegisterEngineLibPath
methods. [1] [2]## Describe Your Changes