Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use after std::move #1844

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix: use after std::move #1844

merged 1 commit into from
Jan 7, 2025

Conversation

vansangpfiev
Copy link
Contributor

This pull request includes changes to the engine/services/engine_service.cc file to improve the handling of paths in the LoadEngine and RegisterEngineLibPath methods. The most important changes involve the removal of buggy std::move (use after move) operations when pushing back paths into the std::vector.

Codebase simplification:

  • engine/services/engine_service.cc: Removed unnecessary std::move operations when pushing cuda_path and engine_dir_path into the paths vector in both the LoadEngine and RegisterEngineLibPath methods. [1] [2]## Describe Your Changes

@vansangpfiev vansangpfiev requested a review from namchuai January 7, 2025 02:10
@vansangpfiev vansangpfiev merged commit e286092 into dev Jan 7, 2025
5 checks passed
@vansangpfiev vansangpfiev deleted the fix/use-after-move branch January 7, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants