Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: filter conventional commit types #113

Closed
Uninen opened this issue Jul 17, 2023 · 6 comments
Closed

Feature request: filter conventional commit types #113

Uninen opened this issue Jul 17, 2023 · 6 comments

Comments

@Uninen
Copy link

Uninen commented Jul 17, 2023

First, Thank You for this simple and easy to use tool! 🙏

When using a changelog template you get something like this:

### Feature

- feat: my feature

when the conventional commit types are known, and when the template is used, it would be nice to be able to filter away the redundant types from the beginning of the commit message. Ie:

### Feature

- my feature

### Unkown

- notconventional: other commit

Latter is much more readable and human-friendly -- would be nice to be able to do this 👍

@jaywcjlove
Copy link
Owner

@Uninen Do you want to remove the feat: in the commit?

@Uninen
Copy link
Author

Uninen commented Jul 17, 2023

Yes, for all the known conventional types.

jaywcjlove added a commit that referenced this issue Jul 17, 2023
@jaywcjlove
Copy link
Owner

@Uninen

show-emoji:
description: 'Show emoji icons.'
default: 'true'
required: false

@Uninen
Copy link
Author

Uninen commented Jul 17, 2023

Don't understand the relevance of above. I've disabled the emojis already, but they don't affect the commit row text in any way (other than the emoji, that is)?

Again, here's the current output:

## Features:
- feat: add feature 1
- feat: add feature 2

Desired output:

## Features:
- add feature 1
- add feature 2

@jaywcjlove
Copy link
Owner

@Uninen

- name: Generate Changelog (show-emoji test)
# uses: jaywcjlove/changelog-generator@main
id: changelogEmoji
uses: ./
with:
filter: '[R|r]elease[d]\s+[v|V]\d(\.\d+){0,2}'
show-emoji: false
remove-type: true

jaywcjlove added a commit that referenced this issue Jul 17, 2023
@Uninen
Copy link
Author

Uninen commented Jul 17, 2023

Wow, brilliant. Thanks for adding this! 🙏

@Uninen Uninen closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants