-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate completely static page #97
Comments
@Regenhardt Currently, the dark/light theme switch, Markdown preview (as a web component), and code copying features all rely on JavaScript. Is it possible to modify only the Markdown preview part? If so, I can make the changes quickly. |
That could be enough I think. I guess it depends on what other elements are already in the layout before running the scripts, in order for the markdown part to be properly displayed. |
@Regenhardt Upgrade v5.0 |
Happy new year! Upgraded to v5, something is broken now, not sure why. Downgraded to make sure, and it works with the same setup. Here's my console output:
Reading it again, I just realized some paths start like |
I also get an error with the latest version, although a different one:
Here's my (unchanged) configuration for the GH Actions workflow which has been working until v5: - name: Generate index.html file
uses: jaywcjlove/markdown-to-html-cli@main
with:
source: README.md
output: index.html
title: flatpak.mser.at
description: Various things missing from Flathub
favicon: [removed from snippet because of length]
github-corners: https://github.com/mserajnik/flatpak.mser.at |
@Regenhardt @mserajnik It looks like I fixed it. upgrade v5.0.2 |
I can confirm it's working again for me now. Thanks! |
Yes works very nicely now, thank you! |
Currently, the cli tool generates an html file with embedded javascript, which in turn creates the dark mode toggle, github corner, and maybe some other stuff affecting layout/design.
This creates a worse site when viewed with scripts disabled.
Could the generator instead fully generate the final html so the final state will always be loaded directly, without having to run scripts for it to be finished?
The text was updated successfully, but these errors were encountered: