Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New middleware example breaking acks to handler #417

Closed
jdlombardozzi opened this issue Nov 14, 2019 · 0 comments · Fixed by #418
Closed

New middleware example breaking acks to handler #417

jdlombardozzi opened this issue Nov 14, 2019 · 0 comments · Fixed by #418

Comments

@jdlombardozzi
Copy link
Contributor

I think we need to update the example DemoMiddleware in middleware_worker.rb. In this example, the middleware doesn't return worker result and will always result in a noop call to the handler.
jdlombardozzi added a commit to jdlombardozzi/sneakers that referenced this issue Nov 14, 2019
@jdlombardozzi
Update example middleware worker
56e6b27 
Addition to fix jondot#417

Update DemoMiddleware to return worker result for property handling
@jdlombardozzi jdlombardozzi mentioned this issue Nov 14, 2019
Merged
hedacharon pushed a commit to kontentcore/sneakers that referenced this issue Apr 21, 2021
@jdlombardozzi
Update example middleware worker
a726886 
Addition to fix jondot#417

Update DemoMiddleware to return worker result for property handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update example middleware worker jdlombardozzi/sneakers
1 participant
@jdlombardozzi