fix: save new payment method flow #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25harsh
requested changes
Oct 30, 2024
Shivam25092001
force-pushed
the
fix-pmm-onaddButtonClick
branch
from
7fb9887 to
bd49749
Compare
aashu331998
reviewed
Nov 4, 2024
src/hooks/AllPaymentHooks.res
Outdated
| ~body: PaymentMethodListType.redirectType | ||
| ) => { | ||
| let paymentMethodId = | ||
| String.split(nativeProp.clientSecret, "_secret_")->Array.get(0)->Option.getOr("") |
There was a problem hiding this comment.
add this logic at top level while storing the clientsecret in the sdk types
There was a problem hiding this comment.
In payments flow, we extract the payment-id from client-secret in the hook itself.
As implemented here: useRedirectHook in AllPaymentHooks.res.
Also do we get any added advantage for extracting it at the top level?
There was a problem hiding this comment.
yes we have to extract at the top level because the logic may change "secret" also if someone uses the oss version if he makes any changes he don't have to look at multiple places, please create one more field in SDK types and while storing the client secret store the id as well
Shivam25092001
force-pushed
the
fix-pmm-save-pm-action
branch
from
42ead09 to
62fe42c
Compare
Shivam25092001
commented
Nov 7, 2024
Shivam25092001
force-pushed
the
fix-pmm-save-pm-action
branch
from
62fe42c to
0915f24
Compare
25harsh
force-pushed
the
main
branch
2 times, most recently
from
3988dd0 to
3230e5e
Compare
Shivam25092001
force-pushed
the
fix-pmm-save-pm-action
branch
from
4d9a7fb to
df39098
Compare
aashu331998
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCREEN RECORDING
This video depicts:
Screen.Recording.2024-11-25.at.7.07.50.PM.mov
ADDED
Add new payment method.FIXED