Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added fix for google_pay and apple_pay #630

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: added fix for google_pay and apple_pay #630

merged 1 commit into from
Sep 26, 2024

Conversation

ArushKapoorJuspay
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  1. GooglePay was not appearing in tabs even when session_token is present.
  2. ApplePay appearing in tabs when session_token in not present

How did you test it?

  1. Test GooglePay and ApplePay in tabs based on session_token. (also try by adding throttling)
  2. Sanity is also required

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@ArushKapoorJuspay ArushKapoorJuspay self-assigned this Sep 20, 2024
@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Sep 20, 2024
@ArushKapoorJuspay ArushKapoorJuspay force-pushed the fix/wallets-in-tabs branch 2 times, most recently from 2f59305 to 235ca5e Compare September 26, 2024 12:32
PritishBudhiraja
PritishBudhiraja approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise :)

@PritishBudhiraja PritishBudhiraja merged commit 95d7bb3 into main Sep 26, 2024
3 checks passed
@PritishBudhiraja PritishBudhiraja deleted the fix/wallets-in-tabs branch September 26, 2024 12:56
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Sep 26, 2024
akash-c-k pushed a commit that referenced this pull request Sep 26, 2024
@semantic-release-bot
chore(release): 0.91.1 [skip ci]
458ee87 
## [0.91.1](v0.91.0...v0.91.1) (2024-09-26)

### Bug Fixes

* added fix for google_pay and apple_pay ([#630](#630)) ([95d7bb3](95d7bb3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

Assignees

@ArushKapoorJuspay ArushKapoorJuspay

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArushKapoorJuspay @PritishBudhiraja