Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: customMessageForCardTerms prop added #705

Merged
merged 1 commit into from
Sep 26, 2024
Merged

feat: customMessageForCardTerms prop added #705

merged 1 commit into from
Sep 26, 2024

Conversation

PritishBudhiraja
Copy link
Collaborator

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added customMessageForCardTerms for providing custom message support for card Terms

How did you test it?

via passing from the Checkform.js

  const options = {
    ...,
    customMessageForCardTerms: "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nulla consequat libero nec bibendum tempor.",
  };

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Sep 25, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this Sep 25, 2024
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@PritishBudhiraja PritishBudhiraja merged commit c30558f into main Sep 26, 2024
3 checks passed
@PritishBudhiraja PritishBudhiraja deleted the custom-card-terms-message branch September 26, 2024 12:05
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Sep 26, 2024
akash-c-k pushed a commit that referenced this pull request Sep 26, 2024
@semantic-release-bot
chore(release): 0.90.0 [skip ci]
7a27b83 
# [0.90.0](v0.89.2...v0.90.0) (2024-09-26)

### Features

* customMessageForCardTerms prop added ([#705](#705)) ([c30558f](c30558f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakksham7 sakksham7 sakksham7 approved these changes

@ArushKapoorJuspay ArushKapoorJuspay ArushKapoorJuspay approved these changes

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

Assignees

@PritishBudhiraja PritishBudhiraja

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PritishBudhiraja @ArushKapoorJuspay @sakksham7