This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
[enhancement] Add CPS to the HUD #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: scorbett123 <[email protected]>
5HT2
reviewed
Feb 6, 2021
5HT2
suggested changes
Feb 6, 2021
src/main/kotlin/org/kamiblue/client/gui/hudgui/elements/misc/CPS.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/kamiblue/client/gui/hudgui/elements/misc/CPS.kt
Outdated
Show resolved
Hide resolved
5HT2
changed the title
5HT2
added
-gui
--changes-requested
Signed-off-by: scorbett123 <[email protected]>
Signed-off-by: lv <[email protected]>
|
Thanks. |
|
I tested and the decimal places seem redundant since they're always .00, can I just remove that? |
|
If you change the time it is being measured over (so it is anything except 1) then it will display with decimals, however if you don't think that they are worth it go ahead and remove them. |
Signed-off-by: lv <[email protected]>
|
Ahh will do some more testing then |
Signed-off-by: lv <[email protected]>
Luna5ama
suggested changes
Feb 6, 2021
Comment on lines
34
to
37
| safeListener<TickEvent.ClientTickEvent> { | ||
| // This needs to happen whenever running else it will continue to show a score after clicking has stopped. | ||
| clicks.removeIf { it < System.currentTimeMillis() - averageSpeedTime } | ||
| } |
There was a problem hiding this comment.
You can do this in updateText() instead of making new listener
| description = "Display your clicks per second." | ||
| ) { | ||
|
|
||
| private val averageSpeedTime by setting("Average Speed Time", 1000, 500..5000, 100, description = "The period of time to measure, in ms") |
There was a problem hiding this comment.
Maybe use seconds instead of making big numbers
|
I did more testing and found different settings were inaccurate or pretty useless, so I removed it. Thanks for the pull! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CPS indicator to the HUD, also fix the description of notebot to reflect that it can now also do nbs.
closes #1604