Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

[enhancement] Add color bar to Armor #1913

Merged
merged 7 commits into from
Feb 7, 2021
Merged

[enhancement] Add color bar to Armor #1913

merged 7 commits into from
Feb 7, 2021

Conversation

scorbett123
Copy link
Contributor

The title.

closes #1887

@scorbett123
Copy link
Contributor Author

Thanks.

Signed-off-by: lv <[email protected]>
@5HT2
Copy link
Member

5HT2 commented Feb 6, 2021

image
image
There are some quite noticeable visual differences from the vanilla durability bar, would you mind making them more similar?

@5HT2 5HT2 added the --changes-requested Changes need to be made to the pull label Feb 6, 2021
@5HT2 5HT2 changed the title [enhancement] Add colour bar to Armor. [enhancement] Add color bar to Armor Feb 6, 2021
@scorbett123
Copy link
Contributor Author

Does the latest commit seem any better to you?

@Luna5ama
Copy link
Contributor

Luna5ama commented Feb 6, 2021

image
image
There are some quite noticeable visual differences from the vanilla durability bar, would you mind making them more similar?

It doesn't have to be exact since it doesn't need to be fit in the 20 x 20 slot square

@5HT2
Copy link
Member

5HT2 commented Feb 6, 2021

It doesn't have to be exact since it doesn't need to be fit in the 20 x 20 slot square

Yes, but it's significantly worse and doesn't even display properly (look at the top). Also, the slimmer width looks much better imo

@Luna5ama
Copy link
Contributor

Luna5ama commented Feb 6, 2021

It doesn't have to be exact since it doesn't need to be fit in the 20 x 20 slot square

Yes, but it's significantly worse and doesn't even display properly (look at the top). Also, the slimmer width looks much better imo

No it just make better readability

@5HT2
Copy link
Member

5HT2 commented Feb 6, 2021

then at least make the bar consistent

@scorbett123
Copy link
Contributor Author

There was a typo, the latest commit should be better.

@5HT2
Copy link
Member

5HT2 commented Feb 6, 2021

@5HT2
Copy link
Member

5HT2 commented Feb 6, 2021

New rendering is great, thanks

Copy link
Member

@5HT2 5HT2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@5HT2 5HT2 merged commit 1b56817 into kami-blue:master Feb 7, 2021
@scorbett123
Copy link
Contributor Author

Thanks

@5HT2 5HT2 added this to the 2.04.01 milestone Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
--changes-requested Changes need to be made to the pull -gui enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArmorHUD option to use color bar instead of percentage for durability
3 participants