Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix up how we invoke benchmarks #154

Merged
merged 1 commit into from
Aug 12, 2020
Merged

fix up how we invoke benchmarks #154

merged 1 commit into from
Aug 12, 2020

Conversation

kivikakk
Copy link
Owner

Don't make benchmarks a "feature" of a regular test run; put the benchmark in the benches directory so it's invoked with cargo bench.

(Awkwardly, note that cargo bench won't actually work on stable either—use cargo +nightly bench or similar.)

Fixes #151.
/cc @alerque

@alerque
Copy link
Contributor

alerque commented Aug 12, 2020

This seems like a reasonable improvement at least until the #[bench] attribute hits stable.

@kivikakk
Copy link
Owner Author

Great. Will merge.

@kivikakk kivikakk merged commit 082a3fc into main Aug 12, 2020
@kivikakk kivikakk deleted the stable-benchmarks branch August 12, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest releases lost support for Rust stable
2 participants