Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Node Version Manager #5

Merged
merged 1 commit into from
Sep 8, 2024
Merged

feat: Node Version Manager #5

merged 1 commit into from
Sep 8, 2024

Conversation

cafferata
Copy link
Contributor

@cafferata cafferata commented Sep 7, 2024

Added the Node Version Manager file (containing the Node.js version number) similar to .node-version.

Before

nvm use
No .nvmrc file found
Please see `nvm --help` or https://github.com/nvm-sh/nvm#nvmrc for more information.
pnpm install
ERROR: This version of pnpm requires at least Node.js v18.12
The current version of Node.js is v11.15.0
Visit https://r.pnpm.io/comp to see the list of past pnpm versions with respective Node.js version support.

After

nvm use
Found '/koenoe/tvseri.es/.nvmrc' with version <lts/*>
Now using node v20.17.0 (npm v10.8.2)
pnpm install
Lockfile is up to date, resolution step is skipped
Packages: +451
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Downloading [email protected]: 20.39 MB/20.39 MB, done
Downloading @img/[email protected]: 7.10 MB/7.10 MB, done
Progress: resolved 451, reused 0, downloaded 449, added 451, done
node_modules/.pnpm/[email protected]/node_modules/sharp: Running install script, done in 1.7s
Downloading @next/[email protected]: 39.36 MB/39.36 MB, done
node_modules/.pnpm/@[email protected][email protected][email protected]_re_fxele7kxz5tgj2lljjstnode_modules/.pnpm/@[email protected][email protected][email protected]_re_fxele7kxz5tgj2lljjstiqn5hm/node_modules/@vercel/speed-insights: Running postinstall script, done in 24ms

dependencies:
+ @vercel/analytics 1.3.1
+ @vercel/speed-insights 1.0.12
+ class-variance-authority 0.7.0
+ color 4.2.3
+ framer-motion 11.5.4
+ next 15.0.0-canary.144
+ react 19.0.0-rc-14a4699f-20240725
+ react-dom 19.0.0-rc-14a4699f-20240725
+ server-only 0.0.1
+ sharp 0.33.5
+ slugify 1.6.6
+ tailwind-scrollbar-hide 1.1.7
+ use-debounce 10.0.3
+ zustand 4.5.5

devDependencies:
+ @tailwindcss/typography 0.5.15
+ @types/color 3.0.6
+ @types/node 20.16.5
+ @types/react 18.3.5
+ @types/react-dom 18.3.0
+ @typescript-eslint/eslint-plugin 7.18.0
+ @typescript-eslint/parser 7.18.0
+ autoprefixer 10.4.20
+ eslint 8.57.0
+ eslint-config-next 15.0.0-rc.0
+ eslint-plugin-import 2.30.0
+ eslint-plugin-unused-imports 3.2.0
+ husky 9.1.5
+ lint-staged 15.2.10
+ mini-svg-data-uri 1.4.4
+ postcss 8.4.45
+ prettier 3.3.3
+ prettier-plugin-tailwindcss 0.6.6
+ sort-package-json 2.10.1
+ tailwindcss 3.4.10
+ typescript 5.5.4

> [email protected] prepare /koenoe/tvseri.es
> husky

Done in 11.7s

Copy link

vercel bot commented Sep 7, 2024

@cafferata is attempting to deploy a commit to the koenoe Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tvseri.es ✅ Ready (Inspect) Visit Preview Sep 7, 2024 9:12pm

Copy link
Owner

@koenoe koenoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this but I do believe many people are moving away from NVM. It's a bit annoying they require a separate file and don't honour .node-version for example as many other Node Version Tooling does do that, like FNM.

@koenoe koenoe merged commit 3be633a into koenoe:main Sep 8, 2024
1 check passed
@cafferata cafferata deleted the nvm branch September 8, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants