-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linux_aarch64_defconfig to add BPF support #17206
Conversation
Welcome @mattrobinsonsre! |
Hi @mattrobinsonsre. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
I have a list of ISO PRs I'm getting merged, I'll ensure this is included |
ok-to-build-iso |
Hi @mattrobinsonsre, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
/ok-to-test |
I took this for a spin trying to run cilium with this iso. Unfortunately, I still get the following error from cilium-agent:
|
Can you advise how I might test this myself. I know BPF drivers are required for cilium, but I wonder if |
This is the minimal repro:
|
Looking at https://docs.cilium.io/en/stable/operations/system_requirements/ and crosschecking this list with whats in the minikube iso, theres a bunch more missing. |
Update: I am building the minikube iso locally atm and going to investigate what other flags might be missing |
I got everything running, here's a full list of what I added:
|
This was waaay more complex that I though. Many thanks @luna-duclos |
No problem! I'm just happy to help get this support in on my mac :) |
Will you update this PR with the additional flags ? |
Ah yes will do. |
af6e4b0
to
bec612f
Compare
rebased |
This comment has been minimized.
This comment has been minimized.
bec612f
to
3a92f17
Compare
ok-to-build-iso |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ok-to-build-iso |
Hi @mattrobinsonsre, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
BPF support is missing from the arm64 kernel, which breaks for example cilium on that platform
4650fdf
to
6ecb12b
Compare
ok-to-build-iso |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @mattrobinsonsre, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
kvm2 driver with docker runtime
Times for minikube start: 49.2s 50.4s 51.0s 49.5s 55.6s Times for minikube ingress: 27.1s 27.6s 28.7s 23.1s 27.1s docker driver with docker runtime
Times for minikube start: 24.9s 22.3s 21.5s 22.1s 24.7s Times for minikube (PR 17206) ingress: 21.4s 20.8s 20.8s 20.8s 17.8s docker driver with containerd runtime
Times for minikube start: 23.6s 24.3s 21.2s 23.1s 23.0s Times for minikube ingress: 31.3s 31.3s 31.3s 31.3s 30.3s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattrobinsonsre, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
BPF support is missing from the arm64 kernel, which breaks for example cilium on that platform
Fixes #17205