Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kubernetes version default: v1.30.0 and latest: v1.30.0 #18669

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

minikube-bot
Copy link
Collaborator

This PR was auto-generated by make update-kubernetes-version using update-k8s-versions.yml CI Workflow.
Please only merge if all the tests pass.

 M pkg/minikube/bootstrapper/bsutil/testdata/v1.30/containerd-api-port.yaml
 M pkg/minikube/bootstrapper/bsutil/testdata/v1.30/containerd-pod-network-cidr.yaml
 M pkg/minikube/bootstrapper/bsutil/testdata/v1.30/containerd.yaml
 M pkg/minikube/bootstrapper/bsutil/testdata/v1.30/crio-options-gates.yaml
 M pkg/minikube/bootstrapper/bsutil/testdata/v1.30/crio.yaml
 M pkg/minikube/bootstrapper/bsutil/testdata/v1.30/default.yaml
 M pkg/minikube/bootstrapper/bsutil/testdata/v1.30/dns.yaml
 M pkg/minikube/bootstrapper/bsutil/testdata/v1.30/image-repository.yaml
 M pkg/minikube/bootstrapper/bsutil/testdata/v1.30/options.yaml
 M pkg/minikube/constants/constants.go
 M site/content/en/docs/commands/start.md

@minikube-bot minikube-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 17, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 17, 2024
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@spowelljr
Copy link
Member

/retest-this-please

@spowelljr spowelljr force-pushed the auto_bump_k8s_versions branch from f80048a to cfcc925 Compare April 19, 2024 17:59
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18669) |
+----------------+----------+---------------------+
| minikube start | 51.9s    | 51.3s               |
| enable ingress | 27.2s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube start: 52.4s 50.5s 52.5s 54.4s 50.0s
Times for minikube (PR 18669) start: 48.9s 53.3s 50.7s 52.5s 51.3s

Times for minikube ingress: 26.6s 27.5s 27.5s 27.0s 27.5s
Times for minikube (PR 18669) ingress: 28.6s 27.5s 24.1s 28.0s 25.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18669) |
+----------------+----------+---------------------+
| minikube start | 23.2s    | 22.4s               |
| enable ingress | 21.3s    | 22.0s               |
+----------------+----------+---------------------+

Times for minikube start: 24.4s 25.9s 22.0s 22.3s 21.3s
Times for minikube (PR 18669) start: 22.1s 24.4s 23.5s 20.7s 21.1s

Times for minikube ingress: 21.3s 21.3s 21.3s 21.3s 21.3s
Times for minikube (PR 18669) ingress: 21.8s 23.3s 21.8s 21.3s 21.8s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 18669) |
+-------------------+----------+---------------------+
| minikube start    | 22.2s    | 22.3s               |
| ⚠️  enable ingress | 26.9s    | 32.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 18669) start: 22.8s 19.9s 22.8s 22.5s 23.4s
Times for minikube start: 21.0s 19.9s 24.0s 22.9s 23.1s

Times for minikube ingress: 18.8s 21.8s 31.8s 31.8s 30.3s
Times for minikube (PR 18669) ingress: 33.3s 32.3s 31.8s 31.8s 32.3s

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me ! Docker Linux is green and KVM failure doesnt seem to be related to the 1.30 and a flake
it is currently 4th most flaky on kvm https://gopogh-server-tts3vkcpgq-uc.a.run.app/?env=KVM_Linux

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, minikube-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@medyagh medyagh merged commit cf3f525 into kubernetes:master Apr 19, 2024
23 of 39 checks passed
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyper-V_Windows TestStartStop/group/disable-driver-mounts (gopogh) n/a
Docker_Linux_crio_arm64 TestAddons/parallel/MetricsServer (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/LocalPath (gopogh) 0.00 (chart)
KVM_Linux_crio TestAddons/Setup (gopogh) 0.00 (chart)
Docker_Linux_crio TestAddons/parallel/MetricsServer (gopogh) 0.62 (chart)
KVM_Linux TestFunctional/parallel/MountCmd/specific-port (gopogh) 2.50 (chart)
Hyper-V_Windows TestMultiNode/serial/MultiNodeLabels (gopogh) 3.28 (chart)
Hyper-V_Windows TestMultiNode/serial/ProfileList (gopogh) 3.28 (chart)
QEMU_macOS TestFunctional/parallel/CertSync (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 7.14 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 7.14 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants