Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation example about ServerRequestFactory::fromGlobals(). #56

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

maurobonfietti
Copy link
Contributor

@maurobonfietti maurobonfietti commented Oct 13, 2020

Q A
Documentation yes

Description

In the API Documentation, in ServerRequestFactory::fromGlobals() example, I think that instead of:

$request = RequestFactory::fromGlobals(

should be:

$request = ServerRequestFactory::fromGlobals(

Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@boesing boesing added Documentation Enhancement hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com labels Oct 13, 2020
@boesing boesing added this to the 2.5.0 milestone Oct 13, 2020
@weierophinney weierophinney merged commit 84fe3da into laminas:2.5.x Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Enhancement hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants