fix: fix method action regex to extract Route MethodRouter #1154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When added a
MethodRouter
created by axum'spost_service
to the routes in a controller ofloco-rs
, it failed to correctly extract that it was aPOST
method. The scenario can be seen here: an axum post_service use case.The issue originates from the regex here: source code:
Which does not account for the match cases of MethodEndpoint::Route created by the {method}_service series of functions: MethodEndpoint::Route.
To address this issue, I updated the regular expression to include this case. Below is the behavior before and after the modification.
After fixed: