Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide example for mapping into ProtoBuf types #14

Open
gunnarmorling opened this issue Dec 20, 2016 · 6 comments
Open

Provide example for mapping into ProtoBuf types #14

gunnarmorling opened this issue Dec 20, 2016 · 6 comments

Comments

@gunnarmorling
Copy link
Member

No description provided.

@sjaakd sjaakd mentioned this issue May 8, 2017
@eiswind
Copy link
Contributor

eiswind commented May 9, 2017

Is there a way to generify the rule that "permissions" will always be "permissionsList" in the proto? (and vice versa). Otherwise I've updated the example from the pr#25 feedback. Thx.

@filiphr
Copy link
Member

filiphr commented May 9, 2017

What do you mean to generify that permisions will always be permissionsList? Do you want to avoid writing @Mapping(source = "permissions", target = "permissionsList") and the opposite?

That can be done by removing the List suffix in the AccessorNamingStrategy#getPropertyName(ExecutableElement getterOrSetterMethod). I don't know protobuf, but you can theoretically check if you are in a proto builder (the same way you are doing now) and check if the return type is List (can it be some other collection?) then strip the List in the end. With this you won't need to adapt the getElementName().

filiphr pushed a commit that referenced this issue Jul 16, 2017
@filiphr
Copy link
Member

filiphr commented Jul 16, 2017

Example with protobuf 3 has been added. My comments are not implemented in the example.

@vordimous
Copy link

Example with protobuf 3 has been added. My comments are not implemented in the example.

So I have been working through your example and I am at a loss how to get it to work outside of the examples project. Moreso I am using Gradle. This is where I am https://github.com/vordimous/mapstruct-proto

I get this error:
warning: Unmapped target properties: "clearField, clearOneof, mergeFrom, idBytes, emailBytes, unknownFields, mergeUnknownFields, allFields, permissionsValueList".

which I can get around by adding a mapping ignore, however you don't have to do this in your example.

Any ideas @filiphr ?

@alex-lzl
Copy link

I am currently using mapstruct (1.3.0beta1) with Kotlin and gRPC (proto3). The example ProtobufAccessorNamingStrategy doesn't work to handle the mapping between "permissions" and "permissionsList" (the getElementName method doesn't even get called at all). I hate to manually map every collection type explicitly using @ValueMapping, thus did an ugly hack like this and got it working for my purposes:

public class ProtobufAccessorNamingStrategy extends DefaultAccessorNamingStrategy {
/**
* Quick hack to remove the "List" from property name in Protobuf classes
*/
@OverRide
public String getPropertyName(ExecutableElement getterOrSetterMethod) {
String prop = super.getPropertyName(getterOrSetterMethod);
if (prop.endsWith(LIST_SUFFIX)) {
prop = prop.substring(0, prop.length() - 4);
}
return prop;
}
}

@Kavyamanjanatha
Copy link

@filiphr
Do we have any way to solve the issue reported by alex-lzl?
I am also facing same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants