Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue mixing scoped and no-update directives #2448

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

DylanPiercey
Copy link
Contributor

Description

resolves #1664

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Dec 29, 2024

🦋 Changeset detected

Latest commit: 636ae4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base (6ef629b) to head (636ae4c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2448   +/-   ##
=======================================
  Coverage   87.27%   87.28%           
=======================================
  Files         348      348           
  Lines       39449    39454    +5     
  Branches     2561     2561           
=======================================
+ Hits        34431    34436    +5     
  Misses       4992     4992           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit cb3b4b5 into main Dec 29, 2024
10 checks passed
@DylanPiercey DylanPiercey deleted the fix-double-scoped-id branch December 29, 2024 22:53
@github-actions github-actions bot mentioned this pull request Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad id created when using "no-update" and scoped id together
1 participant