Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve parse error locations and aggregate errors #2449

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

DylanPiercey
Copy link
Contributor

@DylanPiercey DylanPiercey commented Dec 30, 2024

Resolves #1328 and #1329

  • Errors from the htmljs-parser will now also display any compile errors as an aggregate error.
  • The class block errors were being bounded to the incorrect end position for the class block.

Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: 640f062

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
marko Patch
@marko/compiler Patch
@marko/runtime-tags Patch
@marko/translator-interop-class-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.29%. Comparing base (c9473f7) to head (640f062).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2449      +/-   ##
==========================================
+ Coverage   87.28%   87.29%   +0.01%     
==========================================
  Files         348      348              
  Lines       39454    39485      +31     
  Branches     2561     2561              
==========================================
+ Hits        34436    34470      +34     
+ Misses       4992     4989       -3     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 6cf4978 into main Dec 30, 2024
10 checks passed
@DylanPiercey DylanPiercey deleted the class-parse-errors branch December 30, 2024 15:02
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DevX: Incorrect error message when with extra curly bracket
1 participant