Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve errors from unresolved taglib paths #2451

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

DylanPiercey
Copy link
Contributor

Description

Resolves #997

Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: 5c45090

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@marko/compiler Patch
marko Patch
@marko/runtime-tags Patch
@marko/translator-interop-class-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.29%. Comparing base (6cf4978) to head (5c45090).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ges/compiler/src/taglib/loader/loadTagFromProps.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2451   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files         348      348           
  Lines       39485    39485           
  Branches     2561     2561           
=======================================
  Hits        34470    34470           
  Misses       4989     4989           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 602eaad into main Dec 30, 2024
9 of 10 checks passed
@DylanPiercey DylanPiercey deleted the improve-resolve-errors branch December 30, 2024 15:31
@github-actions github-actions bot mentioned this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tablib loader should throw if marko-tag.json renderer is not found
1 participant