Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use immutable instead of mutable Swift data #687

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Use immutable instead of mutable Swift data #687

merged 4 commits into from
Dec 30, 2024

Conversation

rgoldberg
Copy link
Contributor

Use immutable instead of mutable Swift data:

  • Use struct instead of class.
  • Use let instead of var.
  • Inline unnecessary variables.
  • Minor code cleanup.

Resolve #686

@rgoldberg
Use Swift immutable instead of mutable data.
ed67678 
Use `struct` instead of `class`.

Requires switching `SoftwareMapAppLibrary.installedApps` property from lazy to eagerly initialized.

Use `let` instead of `var`.

Inline unnecessary variables.

Improve `Bundle` resource reading.

Restrict symbol visibility.

Simplify code.

Partial mas-cli#686

Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg
Remove bundleIdentifier related functions.
5d92266 
Partial mas-cli#686

Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg
Simplify SearchResult.swift.
e6f28eb 
Partial mas-cli#686

Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg
Move captureStream(…) from mas to masTests.
75d6511 
Resolve mas-cli#686

Signed-off-by: Ross Goldberg <[email protected]>
@rgoldberg rgoldberg added the 🧹 cleanup Optimization of (not bug fix for) an existing feature label Dec 30, 2024
@rgoldberg rgoldberg added this to the 1.8.9 milestone Dec 30, 2024
@rgoldberg rgoldberg self-assigned this Dec 30, 2024
@rgoldberg rgoldberg merged commit 48ab1ca into mas-cli:main Dec 30, 2024
3 checks passed
@rgoldberg rgoldberg deleted the 686-immutable branch December 30, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rgoldberg rgoldberg

Labels
🧹 cleanup Optimization of (not bug fix for) an existing feature
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Use immutable instead of mutable Swift data
1 participant
@rgoldberg