Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Fix ]TypeError when using Chat completion #1922

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

parshvadaftari
Copy link
Contributor

Description

Resolves an issue in the chat.completions class where the relevant memories retrieved from the memory client were not being accessed correctly. The relevant_memories variable, which is expected to contain the relevant memories under the key "results", was not being correctly referenced, leading to a TypeError.

Fixes #1913

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

@Dev-Khant
Copy link
Member

@parshvadaftari Thanks for the contribution!

@Dev-Khant Dev-Khant merged commit 721d765 into mem0ai:main Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relevant_memories in mem0/proxy/main.py misisng "result" key when using Ollama and chat completion
2 participants