Add compatibility check of VSIX TargetPlatform #8910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
reviewed
Feb 23, 2022
bobbrow
reviewed
Feb 23, 2022
…nto coleng/detect_wrong_vsix
sean-mcmanus
requested changes
Feb 23, 2022
bobbrow
approved these changes
Feb 23, 2022
Add check for Windows 11.
sean-mcmanus
approved these changes
Feb 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #8908
This should help catch issues with the wrong VSIX being deployed ( microsoft/vscode#141696 ) before other wrong behaviors arise.
Adds an error dialog if the specified target is incompatible. Adds a warning dialog if compatible but not matching (i.e. using x86 on x64 Windows). Note that this check is done against the architecture of VS Code, so an x86 build of VS Code on x64 Windows will appear as x86.
Feedback on the message text would be welcome.
Uses regex to find the XML attribute, as Bob had suggested avoiding incurring use of an XML parser due to the frequency of security vulnerabilities in XML parser libraries.