Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate TSLint to ESLint #266

Closed
KamasamaK opened this issue Mar 31, 2020 · 2 comments
Closed

Migrate TSLint to ESLint #266

KamasamaK opened this issue Mar 31, 2020 · 2 comments
Assignees
Milestone

Comments

@KamasamaK
Copy link
Contributor

TSLint has been deprecated. The migration for vscode already happened with microsoft/vscode#87644. Extension authors are also encouraged to migrate according to the docs, so the samples should be migrated accordingly.

@jrieken
Copy link
Member

jrieken commented Apr 8, 2020

Looks like @mjbvz and @octref have added most tslint.json-files and have therefore inherited ownership...

I agree that having uniform styles is good for our samples, but I think it is wrong to put that in each and every project, instead this should be enforced from the outside. This is important when we author those samples, but not when someone reads a sample.

@jrieken
Copy link
Member

jrieken commented Jun 2, 2020

Thanks @mjbvz

kna pushed a commit to kna/nadesiko3-vscode-extension that referenced this issue Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants