Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Add a setting for the root of server #155

Closed
Heromyth opened this issue Sep 1, 2021 · 2 comments · Fixed by #405
Closed

[Feature request] Add a setting for the root of server #155

Heromyth opened this issue Sep 1, 2021 · 2 comments · Fixed by #405
Assignees
@andreamah
Labels
feature-request Request for new features or functionality on-testplan VS Code - Issue added to test plan
Milestone
January 2023

Comments

@Heromyth
Copy link

Heromyth commented Sep 1, 2021

It seems necessary that a new setting for the root of server like what the LiveServer does.

See liveServer.settings.root in https://github.com/ritwickdey/vscode-live-server/blob/master/docs/settings.md.

Thanks.
@lszomoru lszomoru added the feature-request Request for new features or functionality label Sep 2, 2021
@SuyashSonawane
Copy link

Hi @lszomoru is this issue available for contribution ?

@lszomoru lszomoru self-assigned this Oct 25, 2021
@anghelos anghelos mentioned this issue Nov 25, 2021
Closed
@tonny008
Copy link

tonny008 commented Dec 1, 2021

add another setting for the context path.
so that we can serve liveServer.settings.root to the context path.
for example:
serve ./dist/ to localhost:3000/cool/feature/

@lszomoru lszomoru assigned andreamah and unassigned lszomoru Jul 13, 2022
@andreamah andreamah mentioned this issue Sep 9, 2022
Closed
@kieferrm kieferrm mentioned this issue Nov 6, 2022
Closed
@andreamah andreamah added this to the On Deck milestone Dec 8, 2022
@andreamah andreamah modified the milestones: On Deck, January 2023 Dec 22, 2022
@kieferrm kieferrm mentioned this issue Jan 2, 2023
Closed
@andreamah andreamah mentioned this issue Jan 5, 2023
Merged
andreamah added a commit that referenced this issue Jan 9, 2023
@andreamah
fix bugs with over-eager serverroot applying
00db9cc 
Fixes #155
andreamah added a commit that referenced this issue Jan 10, 2023
@andreamah
Add option to choose root offset for previews (#405)
efbca27 
* progress on adding root prefix

* fix bugs with over-eager serverroot applying
Fixes #155
@andreamah andreamah mentioned this issue Jan 23, 2023
Closed
3 tasks
@andreamah andreamah added the on-testplan VS Code - Issue added to test plan label Jan 23, 2023
@lixvbnet lixvbnet mentioned this issue Mar 18, 2023
Open
@lixvbnet lixvbnet mentioned this issue Dec 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreamah andreamah

Labels
feature-request Request for new features or functionality on-testplan VS Code - Issue added to test plan
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Add option to choose root offset for previews microsoft/vscode-livepreview
5 participants
@Heromyth @lszomoru @tonny008 @andreamah @SuyashSonawane