-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File tree mostly covered by comment pane by default #3227
Comments
The initial height of the webview should be 50% of the total height, which would already be an improvement over the current situation. Bug for that: microsoft/vscode#106585. This would be even better, but probably more work than fixing the bug: microsoft/vscode#123715 |
Thanks for linking these issues @alexr00! As there are already two issues that seem to cover this, would it make sense to close this one? Or is it helpful to have something here tracking the experience on the GHPRI side? |
👍 closing as upstream! |
Use new view size API proposal to set view size weights. Fixes #3227
Use new view size API proposal to set view size weights. Fixes #3227
Filing based on meeting from a few weeks ago: The file tree in the GHPRI view was mostly covered by "Comment and Submit" pane by default. This can be moved, but it was confusing/frustrating to start like this by default.
Upon reviewing the experience, I'm thinking this must have been the below:
Should the bottom comment pane start at a lower point by default, and only be moved/default to higher if the user has previously moved it (i.e. always default to below the last expanded item in the above section's tree)? Or is that already the case / not feasible / not in line with other UI practices?
As it's been a few weeks since we observed this, if I'm misremembering anything from this experience, please also let me know.
The text was updated successfully, but these errors were encountered: