Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File tree mostly covered by comment pane by default #3227

Closed
bamurtaugh opened this issue Jan 3, 2022 · 3 comments · Fixed by #3758
Closed

File tree mostly covered by comment pane by default #3227

bamurtaugh opened this issue Jan 3, 2022 · 3 comments · Fixed by #3758
Assignees
Labels
feature-request Request for new features or functionality on-testplan
Milestone

Comments

@bamurtaugh
Copy link
Member

Filing based on meeting from a few weeks ago: The file tree in the GHPRI view was mostly covered by "Comment and Submit" pane by default. This can be moved, but it was confusing/frustrating to start like this by default.

Upon reviewing the experience, I'm thinking this must have been the below:

image

Should the bottom comment pane start at a lower point by default, and only be moved/default to higher if the user has previously moved it (i.e. always default to below the last expanded item in the above section's tree)? Or is that already the case / not feasible / not in line with other UI practices?

As it's been a few weeks since we observed this, if I'm misremembering anything from this experience, please also let me know.

@bamurtaugh bamurtaugh added the feature-request Request for new features or functionality label Jan 3, 2022
@alexr00
Copy link
Member

alexr00 commented Jan 4, 2022

The initial height of the webview should be 50% of the total height, which would already be an improvement over the current situation. Bug for that: microsoft/vscode#106585.

This would be even better, but probably more work than fixing the bug: microsoft/vscode#123715

@bamurtaugh
Copy link
Member Author

Thanks for linking these issues @alexr00! As there are already two issues that seem to cover this, would it make sense to close this one? Or is it helpful to have something here tracking the experience on the GHPRI side?

@alexr00
Copy link
Member

alexr00 commented Jan 5, 2022

👍 closing as upstream!

@alexr00 alexr00 closed this as completed Jan 5, 2022
@joaomoreno joaomoreno added this to the July 2022 milestone Jul 6, 2022
@joaomoreno joaomoreno reopened this Jul 6, 2022
alexr00 added a commit that referenced this issue Jul 25, 2022
Use new view size API proposal to set view size weights.
Fixes #3227
alexr00 added a commit that referenced this issue Jul 25, 2022
Use new view size API proposal to set view size weights.
Fixes #3227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants