Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically apply terminal environment changes to terminals that have not been interacted with #100193

Closed
DanTup opened this issue Jun 15, 2020 · 1 comment
Closed

Automatically apply terminal environment changes to terminals that have not been interacted with #100193

DanTup opened this issue Jun 15, 2020 · 1 comment
Assignees
@Tyriar
Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2021

Comments

@DanTup
Copy link
Contributor

DanTup commented Jun 15, 2020

If extensions modify terminal variables (using ExtensionContext.EnvironmentVariableCollection), terminals need to be reloaded. If this has happened seconds after the terminal was created (eg. during startup/project open) it seems reasonable that the (unused) terminal could just be immediately recreated, rather than the icon being shown and the user having to do it.

(this was mentioned at #99874 (comment)).

@Tyriar
@DanTup DanTup mentioned this issue Jun 15, 2020
Closed
@Tyriar Tyriar added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities terminal General terminal issues that don't fall under another label labels Jun 15, 2020
@Tyriar Tyriar added this to the Backlog milestone Jun 15, 2020
@Tyriar Tyriar self-assigned this Jun 15, 2020
@Tyriar Tyriar mentioned this issue Jul 13, 2020
Closed
@Tyriar Tyriar mentioned this issue Jan 20, 2021
Closed
@Tyriar Tyriar modified the milestones: Backlog, February 2021 Jan 26, 2021
@Tyriar Tyriar removed the help wanted Issues identified as good community contribution opportunities label Jan 26, 2021
@Tyriar Tyriar mentioned this issue Jan 26, 2021
Closed
@Tyriar Tyriar closed this as completed in 0851852 Feb 2, 2021
@Tyriar Tyriar added author-verification-requested Issues potentially verifiable by issue author verification-needed Verification of issue is requested labels Feb 2, 2021
plainerman pushed a commit to plainerman/vscode that referenced this issue Feb 2, 2021
@Tyriar @plainerman
Env var changes will restart terminal automatically
03a7ffd 
This introduces debounce to reuseTerminal as a safety measure and to
batch env var changes.

Fixes microsoft#100193
MarcoZehe pushed a commit to MarcoZehe/vscode that referenced this issue Feb 3, 2021
@Tyriar @MarcoZehe
Env var changes will restart terminal automatically
35951da 
This introduces debounce to reuseTerminal as a safety measure and to
batch env var changes.

Fixes microsoft#100193
@kieferrm kieferrm mentioned this issue Feb 6, 2021
Closed
70 tasks
@connor4312 connor4312 added the verified Verification succeeded label Feb 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2021
Development

No branches or pull requests
4 participants
@DanTup @Tyriar @connor4312 and others