-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore open/install an extension from the Market Place #10340
Comments
CC: @waderyan @joaomoreno @seanmcbreen With the direct application URL handler changes coming in this next iteration we're working on changes to the Marketplace UX to allow direct installation of extension from Marketplace. We wanted to run a few options by you to get your thoughts as well, as there are a few factors to consider:
Following are two options we're considering: Current preference is toward option 1, the reasoning being:
|
@joaomoreno yeah I like that.
The second step (2 from above) does cause cognitive friction. How many users know what their version is? If we could do the above, but with something making it obvious that if you've updated recently use this one. Here's a slight addition to @joaomoreno's. The goal is to reduce the cognitive friction of having to find out your version. I think its obvious to us how to find the version, but it may or may not be to others. ping @hamenon - see above. |
The issue I have is around discoverability. At least at launch majority of the users will be on the older version which supports only the copy based method. For those users the install button click which is the primary action based on the above design will fail, and they'll then have to click on the arrow portion to choose the appropriate version etc. Also if the idea is to phase out the copy based option eventually wouldn't it make more sense to simplify and have both install options (latest and insiders) present directly as opposed to under a menu? |
@hamenon I think I'm seeing your point. In your mind:
Is that correct? |
We might be in the weeds and losing marginal benefit. I would be in favor of the option below, as long as we add something about finding the version of VS Code. It could be a link to VS Code's docs (we can make a short section on how to find your version). I'm concerned a non trivial number of users won't know what their version is. @joaomoreno thoughts? |
@waderyan Yup, thats exactly it. I see your point about users not knowing what version they are on. We can improve the message below the install to include something like a "Find out yours" link that points to documentation on finding out the VS Code version. |
Sounds good to me! |
cc @seanmcbreen see above on design iterations. |
ping @hamenon @joaomoreno a question came up during our call today. For earlier versions of VS code that do not have the URL handler what will happen if they click the install button? My assumption is nothing will happen because there is no URL handler (i.e. we won't show them a warning or anything). Timing update from Marketplace
|
Closing the exploration as it seems our work is done in macOS and Windows. |
Verification only in Windows and macOS. Format:
|
OSX: Verified vscode-insiders: with Safari, Chrome, Firefox On Windows, if VSCode is already running, its window does not get to the top. The user might not notice anything has happened at all. Removing the verified label again so we can confirm it is working the stable release. |
The idea here is to support URLs such as
vscode:extension/${UUID}
. These could make Code open that extension in its UI, allowing for a fast path towards extension installation from the Marketplace.Code is in https://github.com/joaomoreno/vscode/tree/urlservice
app.on('open-url')
to the last focused WindowonOpenUrl
events and open the extension UIThe text was updated successfully, but these errors were encountered: