Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Context Menu/Actions for Values in the Debug Hover #125763

Closed
hediet opened this issue Jun 8, 2021 · 7 comments · Fixed by #200908
Closed

Support Context Menu/Actions for Values in the Debug Hover #125763

hediet opened this issue Jun 8, 2021 · 7 comments · Fixed by #200908
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded

Comments

@hediet
Copy link
Member

hediet commented Jun 8, 2021

This is the debug hover:

image

I think it would be great if each value has a context menu (or inline buttons) to trigger (contributable) actions.

Built-in actions could be:

  • copy value
  • copy expression
  • watch

Actions contributed by extensions could be:

  • visualize 😉

This is already supported in the sidebar:

image

@hediet hediet added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Jun 8, 2021
@hediet hediet added this to the Backlog milestone Jun 8, 2021
@isidorn
Copy link
Contributor

isidorn commented Jun 8, 2021

@hediet good overall idea and I like it. I think we could implement it fairly easily by adding a new menu type to the hover tree. We can even open it for extensions as you suggested.

However I would be interested in what other apps do you know that have a context menu on the hover? Might this be a sort of an anti pattern? I know that the debug hover is a bit heavy and a context menu might fit well there, but I would be interested in how other products do it. Maybe try out Visual Studio, Chrome Dev Tools and others...

fyi @misolori @connor4312

@miguelsolorio
Copy link
Contributor

I do believe that's using the tree widget, which supports inline actions:

CleanShot 2021-06-08 at 10 46 42@2x

I'd assume either a ellipsis (though there is quite a bit already in these views) orgear:

CleanShot 2021-06-08 at 10 48 01@2x

CleanShot 2021-06-08 at 10 48 46@2x

@hediet
Copy link
Member Author

hediet commented Jun 8, 2021

@hediet good overall idea and I like it. I think we could implement it fairly easily by adding a new menu type to the hover tree. We can even open it for extensions as you suggested.

However I would be interested in what other apps do you know that have a context menu on the hover? Might this be a sort of an anti pattern? I know that the debug hover is a bit heavy and a context menu might fit well there, but I would be interested in how other products do it. Maybe try out Visual Studio, Chrome Dev Tools and others...

fyi @misolori

VS has quite a few nested context menus :D

@hediet
Copy link
Member Author

hediet commented Jun 8, 2021

I'd assume either a ellipsis (though there is quite a bit already in these views) orgear:

CleanShot 2021-06-08 at 10 48 01@2x

I like that really much! Would be awesome if extensions could introduce top level actions (that would be useful for a "visualize" action :D), but I understand if that is costs too much space.

@miguelsolorio
Copy link
Contributor

I think that would be possible since it's a toolbar, we do show more inline actions in peek/diff views:

CleanShot 2021-06-08 at 10 57 38@2x

@isidorn
Copy link
Contributor

isidorn commented Jun 9, 2021

Cool ideas. Maybe just a right click context menu might work best.
But an additional gear on the end to make it discoverable will help. Ellipsis look good in the example you provided but in practice we have a lost of overflowing text and it is all shown with ellipsis, so I think it would be very confusing, as some ellipsis would be clickable and some not...

@misolori is right, it can be made possible if we make it a toolbar, however I would be worried about opening inline actions to extensions since horizontal space is already limited. I would first only open secondary actions - the one behind a context menu. Though I am flexible.

@hediet hediet self-assigned this Jun 9, 2021
@isidorn isidorn assigned roblourens and unassigned isidorn Aug 17, 2021
@connor4312 connor4312 self-assigned this Dec 15, 2023
@connor4312 connor4312 added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Dec 15, 2023
@connor4312 connor4312 modified the milestones: Backlog, December / January 2024 Dec 15, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 15, 2023
@connor4312 connor4312 added the verification-needed Verification of issue is requested label Jan 19, 2024
@connor4312
Copy link
Member

@hediet can you verify this one? 🙂

@hediet hediet added the verified Verification succeeded label Jan 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants