-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global reduced motion config #128595
Comments
Started to implement this with f76d07f, using |
I think this makes sense. However we should have a global workbench setting, and not a setting per area. So the user could just flip one setting, and it is up to various workbench areas to respect this setting. Due to that I suggest to name this |
I agree this should be global and Electron has API to ask the OS for its configuration: https://github.com/electron/electron/blob/44491b023ac2653538b7ac36bb73f3085a938666/docs/api/system-preferences.md#systempreferencesgetanimationsettings |
If we can already get this from the OS as @bpasero says maybe we should just respect it out of the box and we do not need a setting at all. Only in the future if users want to disable this automatic respecting of OS setting we can introduce a setting. So I suggest
|
I think you will always find users that want a setting if you wait long enough. This is probably similar to the settings we have around detecting high contrast theme or dark mode in the OS where we have a setting to override this. |
Added readonly onDidChangeReducedMotion: Event<void>;
isMotionReduced(): boolean; |
@JacksonKearl this is a great start. fyi @bpasero @joaomoreno for animations we use I just tried Apple reduce motion and they do not change mouse hover interaction. So I suggest we keep that. |
Interesting, from Apple's Human Interface Guidelines:
But then they don't disable blinking cursors. Also, with system wide Reduce Motion enabled, I still see blinking cursors everywhere. I think it makes good sense to edit the motion reducing text to include "animation" for queries though, that's what many related settings use already. |
@JacksonKearl thanks for looking into Apple's guidelines. @JacksonKearl I guess that on Windows we can not automatically detect if the user disabled the cursor blink? |
On MacOS (and probably windows too), there's a global "reduce motion" configuration. It would be nice if we could have something similar, possibly using that global value by default.
The text was updated successfully, but these errors were encountered: