Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support additionalTextEdits for inline completions #145537

Closed
jrieken opened this issue Mar 21, 2022 · 1 comment
Closed

Support additionalTextEdits for inline completions #145537

jrieken opened this issue Mar 21, 2022 · 1 comment
Assignees
@hediet
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone
March 2022

Comments

@jrieken
Copy link
Member

jrieken commented Mar 21, 2022

Driven by #126375

When forwarding "normal" completions as inline completion I cannot assign additional text edits. That means, those completions need to be filtered (leading to an inconsistent experience) or additional are ignore (which is the option I chose). Ideally additional edits are supported
@hediet hediet added this to the March 2022 milestone Mar 21, 2022
@hediet hediet closed this as completed in d8a95da Mar 21, 2022
@jrieken
Copy link
Member Author

jrieken commented Mar 21, 2022

Thanks

jrieken added a commit that referenced this issue Mar 21, 2022
@jrieken
forward additionTextEdits to inline completions, #145537, #126375
8a0faf9
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
March 2022
Development

No branches or pull requests
3 participants
@jrieken @hediet and others