Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook rendering screen cheese on load #167806

Closed
jrieken opened this issue Dec 1, 2022 · 4 comments
Closed

Notebook rendering screen cheese on load #167806

jrieken opened this issue Dec 1, 2022 · 4 comments
Assignees
@roblourens @rebornix @mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority notebook-layout papercut 🩸 A particularly annoying issue impacting someone on the team verification-needed Verification of issue is requested
Milestone
On Deck

Comments

@jrieken
Copy link
Member

jrieken commented Dec 1, 2022

  • open .vscode/notebooks/my-endgame.github-issues
  • 🐛 notice how during loading layout shift and ugly overlaps happens

Screenshot 2022-12-01 at 08 55 52

Screen.Recording.2022-12-01.at.08.54.48.mov
@rebornix rebornix assigned mjbvz and unassigned roblourens Dec 1, 2022
@rebornix rebornix added notebook-layout bug Issue identified by VS Code Team member as probable bug labels Dec 1, 2022
@rebornix
Copy link
Member

rebornix commented Dec 1, 2022

It seems we lost the viewport warmup in this scenario.

@roblourens
Copy link
Member

I know we lost the horizontal scrollbar fix due to the editor layout optimizations. Is there something else or is it just that?

@mjbvz mjbvz added this to the Backlog milestone Dec 5, 2022
@roblourens roblourens modified the milestones: Backlog, December 2022 Dec 6, 2022
@roblourens roblourens self-assigned this Dec 6, 2022
@jrieken jrieken added important Issue identified as high-priority papercut 🩸 A particularly annoying issue impacting someone on the team labels Dec 9, 2022
@mjbvz mjbvz modified the milestones: January 2023, On Deck Jan 23, 2023
@kieferrm kieferrm mentioned this issue Feb 4, 2023
Closed
92 tasks
@alexdima alexdima mentioned this issue Feb 13, 2023
Merged
alexdima added a commit that referenced this issue Feb 13, 2023
@alexdima
Piggy back on sync layouts done by others in order to update the line…
e1abdac 
… widths (ref #167806)
alexdima added a commit that referenced this issue Feb 13, 2023
@alexdima
Piggy back on sync layouts done by others in order to update the line…
16b3681 
… widths (#174266)

Piggy back on sync layouts done by others in order to update the line widths (ref #167806)
@rebornix
Copy link
Member

Fixed via #174266

c-claeys pushed a commit to c-claeys/vscode that referenced this issue Feb 16, 2023
@alexdima @c-claeys
Piggy back on sync layouts done by others in order to update the line…
e1f9d4f 
… widths (microsoft#174266)

Piggy back on sync layouts done by others in order to update the line widths (ref microsoft#167806)
@rebornix rebornix added the verification-needed Verification of issue is requested label Feb 17, 2023
@alexdima
Copy link
Member

Catching up with notifications...

I think the PR improves this, but FYI @rebornix this issue was created before we switched to FastRenderedViewLine for long lines via 3ebfaad on Dec 11th, so I think it was a problem before that.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority notebook-layout papercut 🩸 A particularly annoying issue impacting someone on the team verification-needed Verification of issue is requested
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
5 participants
@roblourens @rebornix @jrieken @alexdima @mjbvz