Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quick fix provider for new pwsh preview feedback providers #170484

Closed
Tyriar opened this issue Jan 3, 2023 · 4 comments · Fixed by #170887
Closed

Add quick fix provider for new pwsh preview feedback providers #170484

Tyriar opened this issue Jan 3, 2023 · 4 comments · Fixed by #170887
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-quick-fix terminal-shell-pwsh An issue in the terminal specific to PowerShell, including shell integration verified Verification succeeded
Milestone
January 2023

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 3, 2023

https://github.com/PowerShell/PowerShell/releases/tag/v7.4.0-preview.1

PowerShell/PowerShell#18252

image
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-shell-pwsh An issue in the terminal specific to PowerShell, including shell integration terminal-quick-fix labels Jan 3, 2023
@Tyriar Tyriar added this to the January 2023 milestone Jan 3, 2023
@Tyriar Tyriar self-assigned this Jan 3, 2023
@kieferrm kieferrm mentioned this issue Jan 9, 2023
Closed
Tyriar added a commit that referenced this issue Jan 9, 2023
@Tyriar
Support pwsh general error feedback provider
04dc8ba 
Part of #170484
Tyriar added a commit that referenced this issue Jan 9, 2023
@Tyriar
Support pwsh unix command not found error
6877e7d 
Fixes #170484
@Tyriar Tyriar mentioned this issue Jan 9, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 10, 2023
@Tyriar
Copy link
Member Author

Tyriar commented Jan 23, 2023

To verify this you will need to install pwsh preview from the MS Store

@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jan 23, 2023
@bhavyaus bhavyaus added verification-steps-needed Steps to verify are needed for verification and removed verification-needed Verification of issue is requested labels Jan 25, 2023
@bhavyaus
Copy link
Collaborator

I can see the suggestions after installing pwsh preview but I don't see the quick fix provider. When I start typing. Do I need to invoke it with a keyboard shortcut like in the editor?

@roblourens roblourens added the verification-needed Verification of issue is requested label Jan 26, 2023
@roblourens
Copy link
Member

verification-needed stays when verification-steps-needed gets added, fyi

@Tyriar
Copy link
Member Author

Tyriar commented Jan 26, 2023

  1. Install pwsh preview from MS store
  2. Open a terminal and type a command that doesn't exist but is similar to another, eg. gti
  3. Make sure you get quick fixes for the suggestions output by pwsh

@Tyriar Tyriar removed the verification-steps-needed Steps to verify are needed for verification label Jan 26, 2023
@bhavyaus bhavyaus added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-quick-fix terminal-shell-pwsh An issue in the terminal specific to PowerShell, including shell integration verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

Support pwsh preview error feedback providers microsoft/vscode
4 participants
@roblourens @Tyriar @bhavyaus @vscodenpa