Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git - Deprecate Repository.refs property to improve performance #170838

Closed
6 tasks done
lszomoru opened this issue Jan 9, 2023 · 1 comment
Closed
6 tasks done

Git - Deprecate Repository.refs property to improve performance #170838

lszomoru opened this issue Jan 9, 2023 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality git GIT issues perf verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

lszomoru commented Jan 9, 2023

  • Add new git extension API to query for refs
  • Update git extension not to rely on the refs property
  • Update 1st party extensions to adopt the new git extension API
  • Post announcement of the deprecation to vscode-discussions
  • Update code so that the refs property always returns an empty array
  • Remove the code to keep the refs property from updateModelState
@lszomoru lszomoru added git GIT issues perf labels Jan 9, 2023
@lszomoru lszomoru added this to the January 2023 milestone Jan 9, 2023
@lszomoru lszomoru self-assigned this Jan 9, 2023
@lszomoru lszomoru added the feature-request Request for new features or functionality label Jan 9, 2023
@lszomoru lszomoru modified the milestones: January 2023, February 2023 Jan 20, 2023
@lszomoru lszomoru modified the milestones: February 2023, March 2023 Feb 23, 2023
unexge added a commit to unexge/edamagit that referenced this issue Feb 28, 2023
@lszomoru
Copy link
Member Author

Verification steps:

  1. Open a folder/workspace that contains a git repository
  2. Open the Output window, and switch to the git output channel
  3. Open the Source Control view, and click on the "Refresh" action
    • Confirm that the "Refresh" action produced the following output in the git output channel
      2023-03-13 11:44:14.808 [info] > git config --get commit.template [17ms]
      2023-03-13 11:44:14.812 [info] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) refs/heads/main refs/remotes/main [20ms]
      2023-03-13 11:44:14.977 [info] > git status -z -uall [164ms]
      
  4. Open the command palette and invoke the "Git: Checkout to..." command
    • Confirm that the quick pick widget contains all branches, remote branches, tags
    • Confirm that when opening the quick widget the following output is added to the git output channel
      2023-03-13 11:46:02.340 [info] > git for-each-ref --sort -committerdate --format %(refname) %(objectname) %(*objectname) [61ms]
      

@lszomoru lszomoru added the verification-needed Verification of issue is requested label Mar 13, 2023
@andreamah andreamah added the verified Verification succeeded label Mar 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality git GIT issues perf verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants