Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for OSC52 escape sequence character support for terminal #193508

Closed
ipstone opened this issue Sep 19, 2023 · 3 comments · Fixed by #214262
Closed

Request for OSC52 escape sequence character support for terminal #193508

ipstone opened this issue Sep 19, 2023 · 3 comments · Fixed by #214262
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2024

Comments

@ipstone
Copy link

ipstone commented Sep 19, 2023

Description:

I am using Visual Studio Code's remote SSH terminal to work on a remote machine, and I would like to be able to copy text from the terminal to my local system clipboard. However, it seems that the OSC52 escape sequence character is not supported by the remote SSH terminal.

I would like to request support for the OSC52 escape sequence character in the remote SSH terminal, so that I can copy text from the terminal to my local system clipboard.

Alternatively, if there is another way to specify the terminal to use with remote SSH terminal, that supports copying to the system clipboard, please let me know.

Thank you for your attention to this matter.
@Tyriar
Copy link
Member

Tyriar commented Sep 19, 2023

Upstream tracking issue xtermjs/xterm.js#3260

@Tyriar Tyriar added this to the Backlog milestone Sep 19, 2023
@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. labels Sep 19, 2023
@Tyriar Tyriar mentioned this issue Apr 15, 2024
Closed
@Tyriar Tyriar changed the title Request for OSC52 escape sequence character support for remote SSH terminal Request for OSC52 escape sequence character support for terminal Apr 15, 2024
@Tyriar Tyriar mentioned this issue Apr 22, 2024
Closed
@Tyriar Tyriar modified the milestones: Backlog, May 2024 Apr 22, 2024
@Tyriar Tyriar added the upstream-issue-fixed The underlying upstream issue has been fixed label Apr 22, 2024
@Kas-tle
Copy link

Kas-tle commented May 12, 2024

Currently (at least with Windows using tmux with the integrated terminal when hosting a code server on WSL) I can already copy to the system clipboard by holding shift when selecting text.

@Tyriar Tyriar modified the milestones: May 2024, June 2024 May 30, 2024
@Tyriar Tyriar mentioned this issue Jun 3, 2024
Closed
Tyriar added a commit that referenced this issue Jun 4, 2024
@Tyriar
Support for OSC52 clipboard access
e7b681c 
Fixes #193508
Tyriar added a commit that referenced this issue Jun 4, 2024
@Tyriar
Support for OSC52 clipboard access
30e7857 
Fixes #193508
@Tyriar Tyriar mentioned this issue Jun 4, 2024
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 6, 2024
@ipstone
Copy link
Author

ipstone commented Jun 11, 2024

Awesome work! vscode team keeps amazing me, thanks! @Tyriar

@kieferrm kieferrm mentioned this issue Jun 12, 2024
Closed
50 tasks
@Tyriar Tyriar added verification-needed Verification of issue is requested verified Verification succeeded labels Jun 24, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2024
Development

Successfully merging a pull request may close this issue.

Support for OSC52 clipboard access microsoft/vscode
4 participants
@ipstone @Tyriar @Kas-tle @vscodenpa