Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the diff editor when rendered in narrow containers #221245

Closed
4 tasks done
hediet opened this issue Jul 9, 2024 · 5 comments · Fixed by #223066 or #223477
Closed
4 tasks done

Improve the diff editor when rendered in narrow containers #221245

hediet opened this issue Jul 9, 2024 · 5 comments · Fixed by #223066 or #223477
Assignees
@hediet
Labels
diff-editor Diff editor issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2024

Comments

@hediet
Copy link
Member

hediet commented Jul 9, 2024 •
edited
Loading

Sub-Tasks

Tasks
Preview Give feedback
  3. useInlineViewWhenSpaceIsLimited should have a 'smart' option #216484
    diff-editor feature-request verification-needed verified
    hediet
  4. Diffs from ChatResponseTextEditParts should be inline when narrow #210793
    chat diff-editor feature-request insiders-released polish verification-needed verified
    hediet jrieken
@hediet hediet added diff-editor Diff editor issues feature-request Request for new features or functionality labels Jul 9, 2024
@hediet hediet added this to the July 2024 milestone Jul 9, 2024
@hediet hediet self-assigned this Jul 9, 2024
@kieferrm kieferrm mentioned this issue Jul 14, 2024
Closed
48 tasks
@hediet
Copy link
Member Author

hediet commented Jul 22, 2024 •
edited
Loading

Verification steps: Open inline chat (ctrl+i), enter a query, once it completes, click on "view in chat"

Image

Before:

Image

After, much denser view: (ignore color changes - verify it looks like this)

Image

hediet added a commit that referenced this issue Jul 22, 2024
@hediet
Fixes #221245
fd7f904
@hediet hediet mentioned this issue Jul 22, 2024
Merged
@hediet hediet closed this as completed in 84f63bf Jul 22, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 22, 2024
@hediet hediet added the verification-needed Verification of issue is requested label Jul 22, 2024
@sandy081
Copy link
Member

I do not see inline diff, should I have to enable it?

Image

@DonJayamanne
Copy link
Contributor

Same here

@hediet hediet added the verification-found Issue verification failed label Jul 24, 2024
@hediet hediet reopened this Jul 24, 2024
@vscodenpa vscodenpa removed the unreleased Patch has not yet been released in VS Code Insiders label Jul 24, 2024
@hediet
Copy link
Member Author

hediet commented Jul 24, 2024

Yep, this broke yesterday, thanks for testing!

@hediet hediet mentioned this issue Jul 24, 2024
Merged
@hediet
Copy link
Member Author

hediet commented Jul 24, 2024

Fixed with #223477

@hediet hediet closed this as completed Jul 24, 2024
@hediet hediet removed the verification-found Issue verification failed label Jul 24, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 24, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
diff-editor Diff editor issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2024
6 participants
@DonJayamanne @hediet @rzhao271 @sandy081 @vscodenpa and others