Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the global fetch available in local extension hosts to be the one from Electron #228696

Open
chrmarti opened this issue Sep 16, 2024 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality proxy Issues regarding network proxies
Milestone

Comments

@chrmarti
Copy link
Collaborator

No description provided.

@chrmarti chrmarti added plan-item VS Code - planned item for upcoming proxy Issues regarding network proxies labels Sep 16, 2024
@chrmarti chrmarti added this to the September 2024 milestone Sep 16, 2024
@chrmarti chrmarti self-assigned this Sep 16, 2024
@chrmarti
Copy link
Collaborator Author

Discussion on an issue with manual redirects discovered by test failures in #228476: electron/electron#43715

Node.js chose to not follow the spec on the redirect response object which might make it difficult to use Electron's fetch as a drop-in replacement that should appear to extension the same way Node.js' fetch does.

@chrmarti
Copy link
Collaborator Author

Some headers need to be removed to not break existing use:

// Chromium will abort the request if forbidden headers are set.
// Ref https://source.chromium.org/chromium/chromium/src/+/main:services/network/public/cpp/header_util.cc;l=14-48;
// for additional context.
if (options.isChromiumNetwork) {
req.removeHeader('Content-Length');
}

@chrmarti
Copy link
Collaborator Author

Additional limitations: electron/electron#36733 (comment)

@chrmarti
Copy link
Collaborator Author

Putting on hold until we know how well Node.js' fetch with proxy support added works. (#228697)

@chrmarti chrmarti modified the milestones: November 2024, Backlog Nov 29, 2024
@chrmarti chrmarti removed the plan-item VS Code - planned item for upcoming label Nov 29, 2024
@chrmarti chrmarti reopened this Nov 29, 2024
@chrmarti chrmarti added the feature-request Request for new features or functionality label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality proxy Issues regarding network proxies
Projects
None yet
Development

No branches or pull requests

1 participant